T13578 setup phalcon environment #13628

niden · 2018-12-04T01:52:28Z

Hello!

Type: new feature - code quality
Link to issue: Internals - Set up standardized environment for testing and development #13578

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the Contributing Guidelines?
I have checked that another pull request for this purpose does not exist.
I wrote some tests for this PR.

Container base environment for running tests locally.

Thanks

… for refactoring; Work on image/assets

… on old tests

* 4.0.x: (33 commits) Updated stale to not close issues labelled as bugs Use latest Zephir Parser [#11608] - Removed unused variables [#11608] - Reverting instantiation of the client [#11608] - Removed '_' from variables and methods [#11608] - Refactoring on the connect to check if the object is already initialized/connected [#11608] - Refactoring of the getClient() [#11608] - Fixed tabs [#11608] - Corrections based on review [#10532] - Corrected variable [#10532] - Updated changelog [#10532] - Added case insensitive column map in model [#11608] - Corrected variable name [#11608] - Corrected costructor and changelog [#11608] - Updated the changelog [#11608] - Corrected tests [#11608] - Fixed typos [#11608] - More corrections [#11608] - Modifications to the class; Adjusted tests [#11608] - Changed the comparison for the key on save ...

sergeyklay

I paused at phalcon/db/adapter/pdo/postgresql.zep. I will continue a bit later

sergeyklay · 2018-12-04T05:14:57Z

CHANGELOG-4.0.md

+- Removed deprecated `Phalcon\Cache/Backend/Xcache`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Apc`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Memcache`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Xcache`


Suggested change

- Removed deprecated `Phalcon\Mvc/Model/Metadata/Xcache`

- Removed deprecated `Phalcon\Mvc\Model\Metadata\Xcache`

sergeyklay · 2018-12-04T05:15:15Z

CHANGELOG-4.0.md

+- Removed deprecated `Phalcon\Cache/Backend/Memcache`
+- Removed deprecated `Phalcon\Cache/Backend/Xcache`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Apc`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Memcache`


Suggested change

- Removed deprecated `Phalcon\Mvc/Model/Metadata/Memcache`

- Removed deprecated `Phalcon\Mvc\Model\Metadata\Memcache`

sergeyklay · 2018-12-04T05:15:32Z

CHANGELOG-4.0.md

+- Removed deprecated `Phalcon\Cache/Backend/Apc`
+- Removed deprecated `Phalcon\Cache/Backend/Memcache`
+- Removed deprecated `Phalcon\Cache/Backend/Xcache`
+- Removed deprecated `Phalcon\Mvc/Model/Metadata/Apc`


Suggested change

- Removed deprecated `Phalcon\Mvc/Model/Metadata/Apc`

- Removed deprecated `Phalcon\Mvc\Model\Metadata\Apc`

sergeyklay · 2018-12-04T05:15:45Z

CHANGELOG-4.0.md

+- Removed deprecated `Phalcon\Annotations/Adapter/Xcache`
+- Removed deprecated `Phalcon\Cache/Backend/Apc`
+- Removed deprecated `Phalcon\Cache/Backend/Memcache`
+- Removed deprecated `Phalcon\Cache/Backend/Xcache`


Suggested change

- Removed deprecated `Phalcon\Cache/Backend/Xcache`

- Removed deprecated `Phalcon\Cache\Backend\Xcache`

sergeyklay · 2018-12-04T05:16:02Z

CHANGELOG-4.0.md

+- Removed deprecated `Phalcon\Annotations/Adapter/Apc`
+- Removed deprecated `Phalcon\Annotations/Adapter/Xcache`
+- Removed deprecated `Phalcon\Cache/Backend/Apc`
+- Removed deprecated `Phalcon\Cache/Backend/Memcache`


Suggested change

- Removed deprecated `Phalcon\Cache/Backend/Memcache`

- Removed deprecated `Phalcon\Cache\Backend\Memcache`

sergeyklay · 2018-12-04T05:22:40Z

phalcon/cache/backend/apcu.zep

 	{
 		var prefixedKey, cachedContent;

+		if lifetime < 1 {
+			throw new Exception("The lifetime must be at least 1 second");
+		}


It is strange because this method does not use lifetime at all

Yeah this needs to be removed, and it will once we refactor the cache

sergeyklay · 2018-12-04T05:23:04Z

phalcon/cache/backend/factory.zep

@@ -45,7 +45,7 @@ class Factory extends BaseFactory
 	/**
 	 * @param \Phalcon\Config|array config
 	 */
-	public static function load(var config) -> <BackendInterface>
+	public static function load(var config) -> object


See my comment above

This one I don't think we can change it to the BackendInterface because it inherits from FactoryInterface which is used for other factory classes (say Config, Paginator etc.) If this is not object then we have interface problems in compilation

sergeyklay · 2018-12-04T05:23:58Z

phalcon/cache/backend/file.zep

@@ -80,8 +80,8 @@ class File extends Backend
 		}

 		if fetch safekey, options["safekey"] {
-			if typeof safekey !== "boolean" {
-				throw new Exception("safekey option should be a boolean.");
+			if typeof safekey !== "bool" {


Are you sure that typeof returns exactly "bool" not "boolean"?

Fixed the bool/boolean

sergeyklay · 2018-12-04T05:24:50Z

phalcon/cache/backend/file.zep

-			if typeof safekey !== "boolean" {
-				throw new Exception("safekey option should be a boolean.");
+			if typeof safekey !== "bool" {
+				throw new Exception("safekey option should be a bool.");


IMO, we can safely use full type name in the human readable messages, eg bool -> boolean.

sergeyklay · 2018-12-04T05:25:35Z

phalcon/cache/backend/file.zep

@@ -100,7 +100,7 @@ class File extends Backend
 	/**
 	 * Returns a cached content
 	 */
-	public function get(string keyName, var lifetime = null) -> var | null
+	public function get(string keyName, var lifetime = 1) -> var | null


In fact I can't realize why

Typo that I missed. I was trying to correct the interface so changed the lifetime to int but that did not work in the end. This has been corrected.

* 4.0.x: [#13543] Add more pdo types (#13562)

…r was throwing the scanner off

danhunsaker

Couple of minor tweaks?

danhunsaker · 2018-12-05T02:47:36Z

tests/README.md


-The testing suite can be run on your own machine. The main dependency is  [Codeception][1] which can be installed using [Composer][6]:
+The testing suite can be run on your own machine. The only dependencies for running the testing suite or even developing on Phalcon is [nanobox][9]`. Installation instructions for nanobox can be found [here][10]. Also, the main dependency is [Codeception][1] which can be installed using [Composer][6]:


This is phrased a bit awkwardly... Maybe .... The only dependencies for running the testing suite are [nanobox][9] and [Codeception][1]. Nanobox can also be used for developing Phalcon, and its installation instructions can be found [in the Nanobox documentation][10]. Codeception can be installed using [Composer][6]: or something similar? (also, the [nanobox][9] here isn't rendering as a link...)

danhunsaker · 2018-12-05T02:49:46Z

tests/README.md

@@ -196,3 +214,5 @@ Phalcon Framework Team<br>2017
 [6]: http://getcomposer.org
 [7]: https://github.com/phalcon/cphalcon/tree/master/tests/_proxies
 [8]: https://wiki.archlinux.org/index.php/Environment_variables
+[8]: https://nanobox.io/


I suspect this link isn't working because it's supposed to be a [9], here?

danhunsaker · 2018-12-05T02:51:16Z

tests/README.md

+```sh
+# run this command from project root
+/app $ composer install --dev --prefer-source
+```


This is done automatically via nanobox build, which the first nanobox run will always call...

danhunsaker · 2018-12-05T02:51:54Z

tests/README.md

+```bash
+/app $ wget --no-clobber -O /opt/gonano/bin/zephir https://github.com/phalcon/zephir/releases/download/0.11.7/zephir.phar
+/app $ chmod +x /opt/gonano/bin/zephir
+```


These steps are already in the boxfile...

niden added 30 commits November 3, 2018 19:47

Moved tests to temp folder; Added initial boxfile with services

a9b83e8

Codeception bootstrap

de20ebc

Escaper tests

03fd515

WIP - Modifying tests

9f33d89

[#13578] - Updated docblocks, started work for Config

c735b43

[#13578] - Adjusted docblocks

16d29e3

[#13578] - Added copyright notice; Refactored Config tests

3e67799

[#13578] - Refactored Debug/Dump tests

9b890f1

[#13578] - Work on Messages

290f8f9

[#13578] - Refactored Filter tests

0547022

[#13578] - Moved back _ci folder

f798628

[#13578] - Refactored Security tests

e7a146e

[#13578] - PHPCS fixes

c46d939

[#13578] - Refactored validation messages

d21e743

[#13578] - PHPCS fixes

18233e7

[#13578] - Refactored Text tests

db780d7

[#13578] - WIP Tag test refactoring

fb66086

[#13578] - Refactored Tag

8219bcd

[#13578] - Corrected tests; Added iconv in the boxfile

963a8b1

[#13578] - Minor refactor in assets; Added Asset Filter tests

5e830d0

[#13578] - Added necessary extensions in boxfile. Prepared some tests…

25821d5

… for refactoring; Work on image/assets

[#13578] - PHPCS fixes

767501f

[#13578] - Test corrections

6c5652b

[#13578] - Assets refactoring; DiTrait to setup services; Refactoring…

7002334

… on old tests

[#13578] - Added fixtures in the autoloader

0490055

[#13578] - Refactored Acl tests

f55870f

[#13578] - Test corrections

10ec6a3

[#13578] - Refactored Forms

572ff1d

[#13578] - WIP - Http\Response Request

07a02a9

sergeyklay suggested changes Dec 4, 2018

View reviewed changes

niden added 6 commits December 4, 2018 09:19

[#13578] - Corrections based on review

61994e1

[#13578] - Updated nanobox setup files

26d2e98

[#13578] - Changes based on review

6ad2575

[#13578] - Added boxfile to the .gitignore

92a581b

[#13578] - Added more instructions in the tests/README

494f32a

[#13578] - Merge branch '4.0.x' into T13578-setup-phalcon-environment

859e0e1

* 4.0.x: [#13543] Add more pdo types (#13562)

sergeyklay previously approved these changes Dec 4, 2018

View reviewed changes

[#13578] - Updated README; Adjusted tests after the merge

9edd819

niden dismissed sergeyklay’s stale review via 9edd819 December 4, 2018 23:34

niden added 9 commits December 4, 2018 18:55

[#13578] - Corrected schema file for Postgresql

d70a637

[#13578] - Minor correction; Zephir 0.11.8

f0f0069

[#13578] - Triggering the build

f998341

[#13578] - Correction to the case statement

359c345

[#13578] - Corrected something in the file - cannot see what characte…

a94cbc6

…r was throwing the scanner off

[#13578] - Check env variables

0be76be

[#13578] - Work on the db environment for travis

40294f9

[#13578] - Refactored tests to use dataProviders

e1c56a8

[#13578] - Added again the travis environment variables

999f6a7

niden merged commit cc36024 into phalcon:4.0.x Dec 5, 2018

danhunsaker reviewed Dec 5, 2018

View reviewed changes

niden deleted the T13578-setup-phalcon-environment branch December 5, 2018 03:11

niden mentioned this pull request Dec 11, 2018

Refactor unit-tests #13028

Closed

niden added the documentation Documentation required label Apr 9, 2019

niden added 4.0 enhancement Enhancement to the framework testing Tests related issue and removed documentation Documentation required labels Oct 13, 2019

niden removed this from the 4.0.0 milestone Oct 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T13578 setup phalcon environment #13628

T13578 setup phalcon environment #13628

niden commented Dec 4, 2018

sergeyklay left a comment

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

sergeyklay Dec 4, 2018

sergeyklay Dec 4, 2018

niden Dec 4, 2018

danhunsaker left a comment

danhunsaker Dec 5, 2018

danhunsaker Dec 5, 2018

danhunsaker Dec 5, 2018

danhunsaker Dec 5, 2018

	- Removed deprecated `Phalcon\Mvc/Model/Metadata/Xcache`
	- Removed deprecated `Phalcon\Mvc\Model\Metadata\Xcache`

	- Removed deprecated `Phalcon\Cache/Backend/Xcache`
	- Removed deprecated `Phalcon\Cache\Backend\Xcache`


		The testing suite can be run on your own machine. The main dependency is [Codeception][1] which can be installed using [Composer][6]:
		The testing suite can be run on your own machine. The only dependencies for running the testing suite or even developing on Phalcon is [nanobox][9]`. Installation instructions for nanobox can be found [here][10]. Also, the main dependency is [Codeception][1] which can be installed using [Composer][6]:

T13578 setup phalcon environment #13628

T13578 setup phalcon environment #13628

Conversation

niden commented Dec 4, 2018

sergeyklay left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danhunsaker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment